New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6239] fix: No need for toString() on string (CLI) #6247

Merged

justinmclean merged 1 commit into apache:main from sunxiaojian:improve-cli

Jan 15, 2025

Contributor

sunxiaojian commented Jan 15, 2025 •

edited

Loading

What changes were proposed in this pull request?

Remove unnecessary toSrting() from CLI

Why are the changes needed?

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

N/A


          remove toString() and unused code

92c8932

Contributor Author

sunxiaojian commented Jan 15, 2025

@justinmclean PTAL, thanks

justinmclean approved these changes

View reviewed changes

Member

justinmclean left a comment

LGTM

justinmclean merged commit eb3fb31 into apache:main

27 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet